gabotorresruiz opened a new pull request, #34868: URL: https://github.com/apache/superset/pull/34868
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR addresses theming and visual issues in Time-series charts while significantly improving the TimeTable component architecture through comprehensive refactoring: **Theming Fixes:** - Fixed visual styling issues in Time-series charts - Resolved functional bugs affecting chart rendering - Improved consistency with Ant Design theming tokens **Component Structure Improvements:** - Converted JavaScript files to TypeScript files - Split monolithic TimeTable component into smaller, testable components - Extracted inline components into separate modules with dedicated test files - Reorganized utility functions into dedicated folders with comprehensive tests ### BEFORE/AFTER SCREENSHOTS <!--- Skip this if not applicable --> Before: <img width="308" height="56" alt="wrong_icon" src="https://github.com/user-attachments/assets/635e26b5-98cd-4cdd-a9d3-6186327b9e8d"; /> After: <img width="306" height="59" alt="correct_icon" src="https://github.com/user-attachments/assets/20555546-c6d1-4146-adfb-fea38746e43d"; /> ----------------------------------------------------- Before: <img width="308" height="94" alt="time_series_wrong" src="https://github.com/user-attachments/assets/b9818f98-45e4-4a65-8f5b-be3c54da5391"; /> After: <img width="309" height="92" alt="time_series_correct" src="https://github.com/user-attachments/assets/9e05a644-912b-48e9-92d4-3c2675fb384d"; /> ----------------------------------------------------- Before: <img width="325" height="285" alt="wrong_info_icon" src="https://github.com/user-attachments/assets/e221110e-45f3-4dca-a03b-f26e1b0c9cee"; /> After: <img width="327" height="131" alt="correct_info_icon" src="https://github.com/user-attachments/assets/db6d9dfb-cfb9-48ea-b52c-84c19d862085"; /> ----------------------------------------------------- Before: <img width="304" height="158" alt="no_center_text_tooltip" src="https://github.com/user-attachments/assets/d8e0f28a-cf3d-4d79-ac62-ba100c20c296"; /> After: <img width="302" height="153" alt="center_text_tooltip" src="https://github.com/user-attachments/assets/2cc22307-bd33-4cef-b70f-9e07e34da94c"; /> ----------------------------------------------------- Before:  After:  ----------------------------------------------------- Before: <img width="1283" height="712" alt="image" src="https://github.com/user-attachments/assets/fc1c0831-bde1-4c6c-b6e2-d66a298432c9"; /> After: <img width="1274" height="707" alt="image" src="https://github.com/user-attachments/assets/2510ac04-d3ee-48eb-8be9-f4aca04d1d4a"; /> ----------------------------------------------------- Before: <img width="1270" height="701" alt="bad_visuals_dark_mode_period_pivot" src="https://github.com/user-attachments/assets/f870f52b-87e6-4f94-b2cd-dc4515f91d2f"; /> After: <img width="1283" height="717" alt="good_visuals_dark_mode_period_pivot" src="https://github.com/user-attachments/assets/cce518c4-8cac-4249-8d3e-db77702bda23"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Navigate to a `Time-series Table` chart (or create a new one) 2. Verify charts render correctly with proper theming 3. Test value cell formatting and color coding functionality - You can also test that the `Time-series Period Pivot` chart is also rendering as expected with theming ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
