LevisNgigi commented on code in PR #33831:
URL: https://github.com/apache/superset/pull/33831#discussion_r2305352454
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/VerticalCollapse.tsx:
##########
@@ -45,23 +116,27 @@ const CrossFiltersVerticalCollapse = (props: {
}
return (
- <Collapse
- ghost
- defaultActiveKey="crossFilters"
- expandIconPosition="end"
- items={[
- {
- key: 'crossFilters',
- label: t('Cross-filters'),
- children: (
- <>
- {crossFiltersIndicators}
- <Divider data-test="cross-filters-divider" />
- </>
- ),
- },
- ]}
- />
+ <div css={sectionContainerStyle}>
Review Comment:
Needed specific behaviour and styling for the Cross-filter header that was
not supported by collapse component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
