Re: [PR] fix: add --without-threads flag to Flask dev server for DuckDB compatibility [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #34907:
URL: https://github.com/apache/superset/pull/34907#discussion_r2310844424


##########
docker/docker-bootstrap.sh:
##########
@@ -72,7 +72,7 @@ case "${1}" in
     ;;
   app)
     echo "Starting web app (using development server)..."
-    flask run -p $PORT --reload --debugger --host=0.0.0.0
+    flask run -p $PORT --reload --debugger --without-threads --host=0.0.0.0

Review Comment:
   ### Development Server Threading Disabled <sub>![category 
Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Disabling threads in the Flask development server eliminates parallel 
request handling capability, forcing requests to be processed sequentially.
   
   
   ###### Why this matters
   Sequential request processing will significantly reduce performance under 
multiple concurrent users, as each request must wait for the previous one to 
complete before being handled.
   
   ###### Suggested change ∙ *Feature Preview*
   Consider using `gunicorn` with proper thread/worker configuration for DuckDB 
compatibility instead of disabling threading in Flask's development server. 
Example configuration:
   
   ```bash
   gunicorn --workers=1 --threads=1 'app:app' -p $PORT --host=0.0.0.0
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93ec48a3-7527-4feb-a505-539c931fc56e/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93ec48a3-7527-4feb-a505-539c931fc56e?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93ec48a3-7527-4feb-a505-539c931fc56e?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93ec48a3-7527-4feb-a505-539c931fc56e?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93ec48a3-7527-4feb-a505-539c931fc56e)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:4f9fd917-b0c9-4696-ac56-8daeeb7647c8 -->
   
   
   [](4f9fd917-b0c9-4696-ac56-8daeeb7647c8)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org