martyngigg opened a new pull request, #34935: URL: https://github.com/apache/superset/pull/34935
### SUMMARY Since the theming changes, if an `app_root` is set to a non-empty value, the brand logo failed to render as the `src` link was incorrect. These changes include the app_root prefix similarly to other places across the frontend. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS Add `SUPERSET_APP_ROOT="/workspace/example"` to `docker/.env-local`. Spin up the `docker-compose-light` stack and use the web developer tools to inspect the logo image `src` attribute. Before the change the asset link was missing the "/workspace/example" prefix but it is included after this change. In development, using the webpack server, the image actually still appears as the image is in the `superset/static/assets/images` directory and the webpack server can still find it. I'm not sure how this can be fixed... ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
