bito-code-review[bot] commented on code in PR #34988:
URL: https://github.com/apache/superset/pull/34988#discussion_r2317766332
##########
superset/dashboards/api.py:
##########
@@ -1204,6 +1205,10 @@ def screenshot(self, pk: int, digest: str) ->
WerkzeugResponse:
image = cache_payload.get_image()
except ScreenshotImageNotAvailableException:
return self.response_404()
+
+ filename = get_filename(
+ dashboard.dashboard_title, dashboard.id, skip_id=True
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Null dashboard title causes TypeError</b></div>
<div id="fix">
The `get_filename` function is called with `dashboard.dashboard_title` which
can be `None`, but the function expects a string parameter. This will cause a
`TypeError` when `dashboard_title` is `None`. Add a null check:
`dashboard.dashboard_title or "dashboard"`
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
filename = get_filename(
dashboard.dashboard_title or "dashboard", dashboard.id,
skip_id=True
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/34988#issuecomment-3247683586>#6160a8</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
