bito-code-review[bot] commented on code in PR #33677:
URL: https://github.com/apache/superset/pull/33677#discussion_r2320579253
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -70,27 +70,6 @@ const config: ControlPanelConfig = {
...seriesOrderSection,
['color_scheme'],
['time_shift_color'],
- [
- {
- name: 'seriesType',
- config: {
- type: 'SelectControl',
- label: t('Series Style'),
- renderTrigger: true,
- default: seriesType,
- choices: [
- [EchartsTimeseriesSeriesType.Line, t('Line')],
- [EchartsTimeseriesSeriesType.Scatter, t('Scatter')],
- [EchartsTimeseriesSeriesType.Smooth, t('Smooth Line')],
- [EchartsTimeseriesSeriesType.Bar, t('Bar')],
- [EchartsTimeseriesSeriesType.Start, t('Step - start')],
- [EchartsTimeseriesSeriesType.Middle, t('Step - middle')],
- [EchartsTimeseriesSeriesType.End, t('Step - end')],
- ],
- description: t('Series chart type (line, bar etc)'),
- },
- },
- ],
...showValueSection,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing essential seriesType control
configuration</b></div>
<div id="fix">
The `seriesType` control has been completely removed from the Line chart
control panel. This control is essential for users to select different series
styles (Line, Scatter, Smooth Line, Bar, Step variants). Without it, users lose
the ability to change chart visualization types, breaking core chart
functionality. The control should be restored in its own control row after
`showValueSection`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
...showValueSection,
[
{
name: 'seriesType',
config: {
type: 'SelectControl',
label: t('Series Style'),
renderTrigger: true,
default: seriesType,
choices: [
[EchartsTimeseriesSeriesType.Line, t('Line')],
[EchartsTimeseriesSeriesType.Scatter, t('Scatter')],
[EchartsTimeseriesSeriesType.Smooth, t('Smooth Line')],
[EchartsTimeseriesSeriesType.Bar, t('Bar')],
[EchartsTimeseriesSeriesType.Start, t('Step - start')],
[EchartsTimeseriesSeriesType.Middle, t('Step - middle')],
[EchartsTimeseriesSeriesType.End, t('Step - end')],
],
description: t('Series chart type (line, bar etc)'),
},
},
],
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/33677#issuecomment-3251318219>#c1a0d6</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
