john-bodley commented on a change in pull request #7646: Compile example column
names
URL:
https://github.com/apache/incubator-superset/pull/7646#discussion_r293214161
##########
File path: superset/data/birth_names.py
##########
@@ -64,15 +65,18 @@ def load_birth_names():
obj.filter_select_enabled = True
if not any(col.column_name == 'num_california' for col in obj.columns):
+ col_state = str(column('state').compile(db.engine))
Review comment:
@villebro is this approach favored over using SQLAlchemy's
[quote](https://docs.sqlalchemy.org/en/13/core/internals.html?highlight=dialect#sqlalchemy.sql.compiler.IdentifierPreparer.quote)
function? Asking to learn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
