bito-code-review[bot] commented on code in PR #35005:
URL: https://github.com/apache/superset/pull/35005#discussion_r2320389734
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -489,6 +490,7 @@ export default function transformProps(
{
...entry,
id: `${displayName || ''}`,
+ name: `${displayName || ''}`,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Color scaling broken by name override</b></div>
<div id="fix">
Adding `name` property overwrites the original metric name with display
name, breaking color consistency. The `seriesKey` parameter uses `entry.name`
for color scaling, but will now receive formatted display name instead of
original metric name, causing different series with same underlying metric to
get different colors. Remove the `name` property assignment.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35005#issuecomment-3251015066>#662ccc</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
