mistercrunch commented on code in PR #34876:
URL: https://github.com/apache/superset/pull/34876#discussion_r2323620572
##########
superset-frontend/packages/superset-ui-core/src/theme/types.ts:
##########
@@ -127,6 +127,15 @@ export interface SupersetSpecificTokens {
// Spinner-related
brandSpinnerUrl?: string;
brandSpinnerSvg?: string;
+
+ // ECharts-related
+ /** Global ECharts configuration overrides applied to all chart types */
+ echartsOptionsOverrides?: any;
Review Comment:
Yes it's going to be hard to expose something perfect here. Some bulk
thoughts:
- short of exposing a way for people to use code ( think
`echartOptionsMutator(vizType, theme, echartOptions)` ) there's only so much
you can do with static objects like a json blob. Maybe extensions could expose
this kind of hook, idk
- `echartOptions` very much the theming interface for echarts, lots you can
do here, especially if you're builidng your theme object as code (think
embedded-type use case)
- namespacing overrides could be powerful, by that I mean registering
arbitrary targets in Superset as antd "components", meaning you could go
something like this:
```
const theme = {
"component": {
"anyComponentInSuperset": {
"colorText": "#F00";
"componentSpecificToken": "whatever",
},
}
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
