etr2460 commented on a change in pull request #7702: [sqla] Enforcing ISO 8601
date/timestamp formats
URL:
https://github.com/apache/incubator-superset/pull/7702#discussion_r293485685
##########
File path: superset/assets/src/datasource/DatasourceEditor.jsx
##########
@@ -99,14 +99,23 @@ function ColumnCollectionTable({
label={t('Datetime Format')}
descr={
<div>
- {t('The pattern of the timestamp format, use ')}
+ {t('The pattern of timestamp format. For string use ')}
<a
href="https://docs.python.org/2/library/datetime.html#strftime-strptime-behavior";>
{t('python datetime string pattern')}
</a>
- {t(` expression. If time is stored in epoch format, put
\`epoch_s\` or
- \`epoch_ms\`. Leave \`Database Expression\`
- below empty if timestamp is stored in '
- String or Integer(epoch) type`)}
+ {t(' expression which needs to adhere to the ')}
+ <a href="https://en.wikipedia.org/wiki/ISO_8601";>
+ {t('ISO 8601')}
Review comment:
none of this i18n stuff really works, but since it was bad before I don't
see it worthwhile to fix now (or how best to fix it while still embedding
links). Maybe we should add a TODO here to do the i18n the right way in the
future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
