justinpark opened a new pull request, #35065:
URL: https://github.com/apache/superset/pull/35065

   ### SUMMARY
   Regarding the `json` field in the sqllab execute request, this value was 
defined [a long time ago](https://github.com/apache/superset/pull/514/files) 
and is always sent as a fixed value from the frontend. Additionally, after 
reviewing [the 
code](https://github.com/apache/superset/blob/da7f6efea897efeb54208a8bdb0dd80d72aa4bef/superset/sqllab/sqllab_execution_context.py#L74-L94),
 I could not find any place where this value is actually used.
   Therefore, I have determined that it is unnecessary and will be removing it.
   
   
   ### TESTING INSTRUCTIONS
   CI and specs
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to