korbit-ai[bot] commented on code in PR #35071:
URL: https://github.com/apache/superset/pull/35071#discussion_r2333585643
##########
superset-frontend/src/core/sqlLab.ts:
##########
@@ -102,8 +102,11 @@ export const onDidChangeEditorDatabase: typeof
sqlLabType.onDidChangeEditorDatab
createActionListener(
predicate(QUERY_EDITOR_SETDB),
listener,
- (action: { type: string; queryEditor: { dbId: number } }) =>
- action.queryEditor.dbId,
+ (action: {
+ type: string;
+ dbId?: number;
+ queryEditor: { dbId: number };
+ }) => action.dbId || action.queryEditor.dbId,
Review Comment:
Thank you for clarifying the intended fallback behavior. I'll withdraw my
suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
