mistercrunch commented on code in PR #35066:
URL: https://github.com/apache/superset/pull/35066#discussion_r2335305457
##########
docker-compose-light.yml:
##########
@@ -162,8 +162,11 @@ services:
SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}"
# configuring the dev-server to use the host.docker.internal to connect
to the backend
superset: "http://superset-light:8088";
+ # Webpack dev server configuration
+ WEBPACK_DEVSERVER_HOST: "${WEBPACK_DEVSERVER_HOST:-127.0.0.1}"
Review Comment:
✅ IPv6 Support Already Included:
1. allowedHosts: We already include '::1' (IPv6 localhost) in the allowed
hosts list
2. Host binding: When devserverHost is set to '0.0.0.0',
webpack-dev-server typically binds to both IPv4 and IPv6
by default
3. Docker: Docker containers support IPv6 networking
Potential Considerations:
The '0.0.0.0' binding should work for IPv6, but if someone specifically
wants IPv6-only binding, they could set
WEBPACK_DEVSERVER_HOST='::' (IPv6 equivalent of 0.0.0.0).
We could enhance the allowedHosts to be more IPv6-friendly by adding IPv6
local network patterns, but the current
setup with ::1 should handle most cases.
Should work fine with IPv6! The ::1 in allowedHosts covers IPv6 localhost,
and 0.0.0.0 binding typically handles
both IPv4 and IPv6 traffic in modern Node.js/webpack setups.
Is the reviewer asking about any specific IPv6 scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
