mistercrunch opened a new pull request, #35083:
URL: https://github.com/apache/superset/pull/35083
### ⚡ Key Features
- **Manual Execution**: One-click "Trigger Now" button (⚡) in CRUD list for
immediate alert/report execution
- **Professional UX**: Loading states, toast feedback, permission-aware
display
- **Error Handling**: Intelligent Celery backend detection with helpful
setup guidance
### 🎨 Form Enhancement Bonus
- **Dynamic Asterisks**: Gray by default, red when validation fails across
ALL Superset modals
- **Modern Patterns**: Migrated AlertReportModal fields to ModalFormField
standard
- **Better Defaults**: 1600px screenshot width matching dashboard config
### Technical Implementation
- **Backend**: `/api/v1/report/{id}/execute` REST endpoint with proper RBAC
- **Frontend**: Custom `useExecuteReportSchedule` hook with TypeScript
integration
- **Testing**: 5 comprehensive backend tests + frontend hook tests
- **Quality**: All pre-commit hooks passing, TypeScript compliant
### Impact
- **13 files changed**: 803 insertions, 156 deletions
- **Cross-Modal Enhancement**: Improved form validation UX affects Charts,
Dashboards, Databases, and all modal forms
- **Immediate User Value**: No more waiting for cron schedules to execute
alerts/reports
## Test Plan
- [ ] Test "Trigger Now" button functionality in Alerts & Reports list
- [ ] Verify loading states and error handling
- [ ] Test dynamic asterisk coloring in various modal forms
- [ ] Confirm proper permission gating
- [ ] Validate Celery error messages for development setups
---
Resolves common user pain points while establishing modern, consistent
patterns for future development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
