ismaelricopalasios-maker opened a new issue, #35100:
URL: https://github.com/apache/superset/issues/35100

   ### Inconsistent Text Color Theme Fallback <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The colorTextSecondary fallback to colorText may result in inconsistent text 
color behavior when themes are changed.
   
   
   ###### Why this matters
   If colorTextSecondary is undefined in some themes but defined in others, the 
text color will switch between two different color variables, potentially 
causing unexpected visual changes.
   
   ###### Suggested change ∙ *Feature Preview*
   Use only one theme color variable to ensure consistent behavior across 
themes:
   ```typescript
   color: ${theme.colorText};
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/1b42eaa5-3d9c-416f-bbba-918d78905560)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:5985586c-c923-4a33-aa1a-b00072d49bce -->
   
   
   [](5985586c-c923-4a33-aa1a-b00072d49bce)
   
   _Originally posted by @korbit-ai[bot] in 
https://github.com/apache/superset/pull/35096#discussion_r2337718805_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to