korbit-ai[bot] commented on code in PR #35086:
URL: https://github.com/apache/superset/pull/35086#discussion_r2338358782
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts:
##########
@@ -54,7 +54,9 @@ const getCrossFilterDataMask =
values = [value];
}
- const groupbyValues = values.map(value => labelMap[value]);
+ const groupbyValues = values
+ .map(value => labelMap[value])
+ .filter(Boolean) as string[][];
Review Comment:
filter(Boolean) removes any null/undefined values from the array. In this
context, it prevents errors when labelMap doesn't contain an entry for the
"Other" group by filtering out that undefined result before further processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
