john-bodley commented on a change in pull request #7682: [PoC] SIP-15 Presto
types
URL:
https://github.com/apache/incubator-superset/pull/7682#discussion_r293621447
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -38,25 +44,33 @@
class PrestoEngineSpec(BaseEngineSpec):
+ import pyhive.sqlalchemy_presto
+
engine = 'presto'
+ type_map = pyhive.sqlalchemy_presto._type_map
time_grain_functions = {
Review comment:
This logic would probably be refactored if we rolled this our globally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
