kgabryje commented on code in PR #34674:
URL: https://github.com/apache/superset/pull/34674#discussion_r2339302586
##########
superset/db_engine_specs/base.py:
##########
@@ -1342,11 +1342,10 @@ def extract_errors(
db_engine_custom_errors = {}
- for engine_key in [cls.engine, cls.engine_name]:
- if engine_key and engine_key in config_custom_errors:
- engine_errors = config_custom_errors[engine_key]
- if isinstance(engine_errors, dict):
- db_engine_custom_errors.update(engine_errors)
+ if database_name and database_name in config_custom_errors:
+ database_errors = config_custom_errors[database_name]
+ if isinstance(database_errors, dict):
+ db_engine_custom_errors.update(database_errors)
if not isinstance(db_engine_custom_errors, dict):
Review Comment:
Is there any scenario where db_engine_custom_errors is not a dict? We
initialize it as dict in line 1342, and then update it only with other dicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
