eschutho opened a new pull request, #35125:
URL: https://github.com/apache/superset/pull/35125
## SUMMARY
Fixes two loading screen issues:
1. **Gap in horizontal filter bar** - Removes the 12px top padding that
created a visual gap
2. **Loading screen theming issues** - Sets proper background color for dark
mode and removes fallback "Loading..." text
## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIFS
**Before:**
- White flash in dark mode during loading
- "Loading..." text in Times New Roman font appears before spinner
- Gap at the top of horizontal filter bar
**After:**
- Proper dark/light background from page load
- No loading text, only themed spinner
- No gap in filter bar
## TESTING INSTRUCTIONS
1. Switch to dark mode in Superset settings
2. Navigate to a dashboard with horizontal filter bar
3. Refresh the page and observe:
- No white flash during loading
- No "Loading..." text appears
- Filter bar has no gap at the top
4. Test in light mode to ensure no regressions
## ADDITIONAL INFORMATION
- Removes `${theme.sizeUnit * 3}px` (12px) top padding from horizontal
filter bar
- Uses `colorBgBase` theme token for proper light/dark mode background
- Removes fallback loading text that was causing Times New Roman display
- Changes are backwards compatible and respect existing theming
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
