eschutho opened a new pull request, #35129:
URL: https://github.com/apache/superset/pull/35129
## Summary
- Fixes white flash when loading Superset in dark mode
- Removes unstyled "Loading..." text that appeared in Times New Roman font
- Improves overall loading experience with proper theming
## Problem
The loading screen had several theming issues:
- ❌ White background flash in dark mode (jarring UX)
- ❌ Fallback "Loading..." text displayed in Times New Roman font
- ❌ No respect for current theme's background color
- ❌ Poor visual transition between loading and app
## Solution
**1. Theme-aware background color:**
- Added `background-color: {{ tokens.get('colorBgBase', '#ffffff') }}` to
body
- Uses theme token that automatically adapts to light/dark mode
- Eliminates white flash in dark mode
**2. Remove unstyled loading text:**
- Removed `alt="Loading..."` from branded spinner image
- Removed entire fallback `<div>Loading...</div>` section
- Let React app handle loading states instead of HTML fallback
**3. Better code organization:**
- Moved `{% set tokens = theme_tokens | default({}) %}` to top for better
scope
- Added explanatory comment about React handling loading state
## Visual Impact
- ✅ No more white flash in dark mode
- ✅ No more Times New Roman "Loading..." text
- ✅ Smooth visual transition respecting current theme
- ✅ Consistent background color during loading
## Files Changed
- `superset/templates/superset/spa.html`
## Testing
- Test in both light and dark themes
- Verify no white flash on page load in dark mode
- Confirm loading experience is smooth and themed
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
