geido commented on code in PR #35122:
URL: https://github.com/apache/superset/pull/35122#discussion_r2363395362
##########
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx:
##########
@@ -264,115 +257,76 @@ const ChartContextMenu = (
itemsCount = 1; // "No actions" appears if no actions in menu
}
+ const drillDetailMenuItems = useDrillDetailMenuItems({
+ formData: drillFormData,
+ filters: filters?.drillToDetail,
+ setFilters,
+ isContextMenu: true,
+ contextMenuY: clientY,
+ onSelection,
+ submenuIndex: showCrossFilters ? 2 : 1,
+ setShowModal: setDrillModalIsOpen,
+ dataset: filteredDataset,
+ isLoadingDataset,
+ ...(additionalConfig?.drillToDetail || {}),
+ });
+
if (showCrossFilters) {
const isCrossFilterDisabled =
!isCrossFilteringSupportedByChart ||
!crossFiltersEnabled ||
!filters?.crossFilter;
- let crossFilteringTooltipTitle: ReactNode = null;
- if (!isCrossFilterDisabled) {
- crossFilteringTooltipTitle = (
- <>
- <div>
- {t(
- 'Cross-filter will be applied to all of the charts that use this
dataset.',
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
