mistercrunch commented on PR #35215: URL: https://github.com/apache/superset/pull/35215#issuecomment-3315305769
My main thing would be to handle this through a common solution/UX for all properties modal, so it's DRY and consistent across modals. About loading time, you never really know what could be happening, backend hiccup, super slow connection, ... I hate loading-related flickering, let's find a solution that that minimizes it. The loading-state-in-trigger might be decent (antd has loading states for buttons). Otherwise was thinking a spinner inside the full-size modal might be ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
