rusackas commented on code in PR #35159:
URL: https://github.com/apache/superset/pull/35159#discussion_r2369553637


##########
.github/workflows/superset-frontend.yml:
##########
@@ -143,7 +143,7 @@ jobs:
       - name: tsc
         run: |
           docker run --rm $TAG bash -c \
-          "npm run type"
+          "npm run plugins:build && npm run type"

Review Comment:
   Sorry to keep rambing, but if we DO need it, we might want to try pnpm/bun 
here to speed things up quite a bit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to