rusackas commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2373013454


##########
superset/views/auth.py:
##########
@@ -66,7 +65,7 @@ def activation(self, activation_hash: str) -> 
WerkzeugResponse:
         reg = self.appbuilder.sm.find_register_user(activation_hash)
         if not reg:
             logger.error(LOGMSG_ERR_SEC_NO_REGISTER_HASH, activation_hash)
-            flash(as_unicode(self.false_error_message), "danger")
+            logger.error("Registration activation failed: %s", 
self.false_error_message)

Review Comment:
   @mistercrunch this is one of the errors that used to be (rightly) surfaced 
to users, but now might silent in the UI. These (and other?) server-side 
messages might no longer appear on the frontend. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to