mistercrunch commented on code in PR #35220: URL: https://github.com/apache/superset/pull/35220#discussion_r2373784364
########## superset-frontend/packages/superset-ui-core/src/components/Typography/Typography.test.tsx: ########## @@ -50,7 +50,7 @@ describe('Typography Component', () => { it('renders strong text', () => { render(<Typography.Text strong>Strong Text</Typography.Text>); - expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 500'); + expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 600'); Review Comment: I don't understand why this test needed to change, from my understanding we just moved the default base theme from the frontend to the backend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org