msyavuz opened a new pull request, #35265: URL: https://github.com/apache/superset/pull/35265
## SUMMARY This PR fixes an issue where refreshing a dashboard does not update charts in tabs that haven't been loaded yet. Previously, only charts in tabs that were already visited would refresh, leaving unvisited tabs with stale data. The fix implements lazy refresh behavior for tabs - when a dashboard refresh is triggered, tabs that haven't been loaded yet will automatically refresh their charts when the user switches to them. ## BEFORE/AFTER ### Before - When refreshing a dashboard with multiple tabs, only the charts from tabs that were already loaded would be refreshed - Charts in unvisited tabs would remain stale even after a dashboard refresh ### After - Dashboard refresh marks the refresh timestamp - When switching to a previously unloaded tab after a refresh, that tab's charts are automatically refreshed - This matches the initial loading behavior where tabs load lazily as the user navigates to them ## TESTING INSTRUCTIONS 1. Create a dashboard with 3 tabs, and add one chart on each tab 2. Wait a couple of minutes so data gets cached on all charts 3. Access the dashboard (loads on first tab) and navigate to the second tab 4. Trigger a dashboard refresh using the refresh button 5. Navigate to the third tab 6. Verify that the third tab's charts are refreshed when you switch to it (you should see loading indicators) ## ADDITIONAL INFORMATION - Added tracking of tab activation times to determine when tabs need refreshing - Added `lastRefreshTime` to dashboard state to track when refreshes occur - Tab component now checks if it needs to refresh when becoming visible - Created utility function `getChartIdsFromComponent` to get all chart IDs within a tab Fixes the issue where dashboard refresh doesn't affect unloaded tabs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
