mistercrunch commented on code in PR #35256: URL: https://github.com/apache/superset/pull/35256#discussion_r2380613677
########## superset-frontend/src/components/Datasource/DatasourceModal/DatasourceModal.useModal.test.tsx: ########## @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + render, + screen, + fireEvent, + act, + defaultStore as store, +} from 'spec/helpers/testing-library'; +import fetchMock from 'fetch-mock'; +import { Modal } from '@superset-ui/core/components'; +import mockDatasource from 'spec/fixtures/mockDatasource'; +import DatasourceModal from '.'; + +const mockedProps = { + datasource: mockDatasource['7__table'], + addSuccessToast: jest.fn(), + addDangerToast: jest.fn(), + onChange: jest.fn(), + onHide: jest.fn(), + show: true, + onDatasourceSave: jest.fn(), +}; + +describe('DatasourceModal - useModal Hook Tests', () => { Review Comment: It's not great to loose review cycles over an inforced-by-code-review guideline that's super widely used in the codebase. ``` 17:52 $ git grep "describe(" | wc -l 1126 ``` There are more productive way to spend our time. Can we lift the ban until someone who cares enough about the rule implements a lint rule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
