geido commented on code in PR #35252:
URL: https://github.com/apache/superset/pull/35252#discussion_r2383977345
##########
superset-frontend/src/pages/RowLevelSecurityList/RowLevelSecurityList.test.tsx:
##########
@@ -173,19 +173,19 @@ describe('RuleList RTL', () => {
const table = screen.getByRole('table');
expect(table).toBeInTheDocument();
- const nameColumn = await within(table).findByText('Name');
- const filterTypeColumn = await within(table).findByText('Filter Type');
- const groupKeyColumn = await within(table).findByText('Group Key');
- const clauseColumn = await within(table).findByText('Clause');
- const modifiedColumn = await within(table).findByText('Last modified');
- const actionsColumn = await within(table).findByText('Actions');
-
- expect(nameColumn).toBeInTheDocument();
- expect(filterTypeColumn).toBeInTheDocument();
- expect(groupKeyColumn).toBeInTheDocument();
- expect(clauseColumn).toBeInTheDocument();
- expect(modifiedColumn).toBeInTheDocument();
- expect(actionsColumn).toBeInTheDocument();
+ const nameColumns = await within(table).findAllByText('Name');
Review Comment:
So duplication is now getting worse with the upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
