betodealmeida commented on code in PR #35332:
URL: https://github.com/apache/superset/pull/35332#discussion_r2389155579


##########
superset/db_engine_specs/doris.py:
##########
@@ -116,7 +116,7 @@ class DorisEngineSpec(MySQLEngineSpec):
     )
     encryption_parameters = {"ssl": "0"}
     supports_dynamic_schema = True
-    supports_catalog = supports_dynamic_catalog = 
supports_cross_catalog_queries = True
+    supports_catalog = supports_dynamic_catalog = True

Review Comment:
   Let's leave a comment here so we have more context in the future:
   ```suggestion
       supports_catalog = supports_dynamic_catalog = True
       # while technically supported by Doris, this generates invalid table 
identifiers
       supports_cross_catalog_queries = False
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to