bito-code-review[bot] commented on code in PR #35437:
URL: https://github.com/apache/superset/pull/35437#discussion_r2396019531
##########
docs/yarn.lock:
##########
@@ -3050,7 +3050,34 @@
ramda-adjunct "^5.0.0"
unraw "^3.0.0"
-"@swagger-api/apidom-core@>=1.0.0-beta.41 <1.0.0-rc.0",
"@swagger-api/apidom-core@^1.0.0-beta.46":
+"@swagger-api/apidom-ast@^1.0.0-beta.50":
+ version "1.0.0-beta.50"
+ resolved
"https://registry.yarnpkg.com/@swagger-api/apidom-ast/-/apidom-ast-1.0.0-beta.50.tgz#9e0f4132ea54dd4fca0f31f919a0c5aad12d93c1";
+ integrity
sha512-uUBUm6J6KlyKppyfS7DIW37De6oyMVIpHYmaNV3YAaDMuRMov5KHHWXKbqWlI+l493OljOcXEqDIPeLzm6B5PQ==
+ dependencies:
+ "@babel/runtime-corejs3" "^7.26.10"
+ "@swagger-api/apidom-error" "^1.0.0-beta.50"
+ "@types/ramda" "~0.30.0"
+ ramda "~0.30.0"
+ ramda-adjunct "^5.0.0"
+ unraw "^3.0.0"
+
+"@swagger-api/apidom-core@>=1.0.0-beta.50 <1.0.0-rc.0",
"@swagger-api/apidom-core@^1.0.0-beta.50":
+ version "1.0.0-beta.50"
+ resolved
"https://registry.yarnpkg.com/@swagger-api/apidom-core/-/apidom-core-1.0.0-beta.50.tgz#d9ed6821d1b38b66ed8cd0b8d8bf5de997354178";
+ integrity
sha512-9N7ySdyzx/3kUnprAi63GQNt+Kq8VUvErwDgPcMRAsZX8jUhk9KLJ9N0fup4mWm6+xGs0JH35wxBxnanS6aiqw==
+ dependencies:
+ "@babel/runtime-corejs3" "^7.26.10"
+ "@swagger-api/apidom-ast" "^1.0.0-beta.50"
+ "@swagger-api/apidom-error" "^1.0.0-beta.50"
+ "@types/ramda" "~0.30.0"
+ minim "~0.23.8"
+ ramda "~0.30.0"
+ ramda-adjunct "^5.0.0"
+ short-unique-id "^5.3.2"
+ ts-mixer "^6.0.3"
+
+"@swagger-api/apidom-core@^1.0.0-beta.46":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dependency version conflict</b></div>
<div id="fix">
The yarn.lock file is keeping both old
(@swagger-api/apidom-core@^1.0.0-beta.46) and new
(@swagger-api/apidom-core@^1.0.0-beta.50) versions of swagger-api dependencies,
which will cause version conflicts. swagger-client 3.35.7 specifically requires
>=1.0.0-beta.50 <1.0.0-rc.0, so the beta.46 versions should be removed to
prevent runtime issues.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
-"@swagger-api/apidom-core@^1.0.0-beta.46":
- version "1.0.0-beta.46"
- resolved
"https://registry.yarnpkg.com/@swagger-api/apidom-core/-/apidom-core-1.0.0-beta.46.tgz#6c879f6cf9e67fa0cc36955d3a7f0dd185e36b4f";
- integrity
sha512-CC8SdAkjSA/l31xfg5l4860cixbYABIXamJeNcXJr+O1z9YNKHIIENeI0zIwORk/TYUaSOg1KUjDnV2Pdctufg==
- dependencies:
- "@babel/runtime-corejs3" "^7.26.10"
- "@swagger-api/apidom-ast" "^1.0.0-beta.46"
- "@swagger-api/apidom-error" "^1.0.0-beta.46"
- "@types/ramda" "~0.30.0"
- minim "~0.23.8"
- ramda "~0.30.0"
- ramda-adjunct "^5.0.0"
- short-unique-id "^5.3.2"
- ts-mixer "^6.0.3"
@@ -3102,3 +3102,0 @@
-"@swagger-api/apidom-error@^1.0.0-beta.46":
- version "1.0.0-beta.46"
- resolved
"https://registry.yarnpkg.com/@swagger-api/apidom-error/-/apidom-error-1.0.0-beta.46.tgz#fe9039c23ac655930e1f06d99b8ea28bc40d905d";
- integrity
sha512-AN2ZOHp7gtVsCa6hWxH3nk/1PS7bRtqDVCih3C5qA8k5JfHjP2wfks7b14Ns971SUvDD/SubaCmXmu0CRBHLag==
- dependencies:
- "@babel/runtime-corejs3" "^7.20.7"
@@ -3119,3 +3119,0 @@
-"@swagger-api/apidom-json-pointer@^1.0.0-beta.40 <1.0.0-rc.0",
"@swagger-api/apidom-json-pointer@^1.0.0-beta.46":
- version "1.0.0-beta.46"
- resolved
"https://registry.yarnpkg.com/@swagger-api/apidom-json-pointer/-/apidom-json-pointer-1.0.0-beta.46.tgz#40edcaf5fddc5c748ed4084c9042a2669cbf507c";
- integrity
sha512-JsbCkYDG7rbf1QmEhtXgbuCGJ4oW+uWDOEnW+Gar49sjk/OKX/2GSGUpywRstnZcopjNarLcEx/H1mHRLoL45A==
- dependencies:
- "@babel/runtime-corejs3" "^7.26.10"
- "@swagger-api/apidom-core" "^1.0.0-beta.46"
- "@swagger-api/apidom-error" "^1.0.0-beta.46"
- "@swaggerexpert/json-pointer" "^2.10.1"
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35437#issuecomment-3358302249>#a10275</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
