john-bodley commented on a change in pull request #7717: [WIP] Refactor
testconn to use get_sqla_engine
URL:
https://github.com/apache/incubator-superset/pull/7717#discussion_r294613255
##########
File path: superset/views/core.py
##########
@@ -1796,46 +1795,29 @@ def testconn(self):
uri = request.json.get('uri')
db_name = request.json.get('name')
impersonate_user = request.json.get('impersonate_user')
- database = None
+
+ # extras is sent as json, but required to be a string in the
Database model
+ extra_json = request.json.get('extras', {})
+ extra_str = json.dumps(extra_json)
+
if db_name:
- database = (
+ existing_database = (
Review comment:
Would you be able to clarify the difference between `existing_database` and
`database` (defined below)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
