korbit-ai[bot] commented on code in PR #35420:
URL: https://github.com/apache/superset/pull/35420#discussion_r2395149429
##########
superset/sql/dialects/pinot.py:
##########
@@ -95,3 +101,8 @@ def datatype_sql(self, expression: exp.DataType) -> str:
return f"{type_sql} UNSIGNED{nested}"
return f"{type_sql}{nested}"
+
+ def cast_sql(self, expression: exp.Cast, safe_prefix: str | None =
None) -> str:
+ # Pinot doesn't support MySQL's TIMESTAMP() function
+ # Use standard CAST syntax instead
+ return super(MySQL.Generator, self).cast_sql(expression,
safe_prefix)
Review Comment:
I see. Thank you for clarifying. The intentional bypass of the
MySQL.Generator class makes sense if Pinot requires different casting behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
