mistercrunch commented on a change in pull request #7720: [SQL Lab] Add JSON
modal when clicking on cells with JSON objects
URL:
https://github.com/apache/incubator-superset/pull/7720#discussion_r295016695
##########
File path: superset/assets/src/components/FilterableTable/FilterableTable.jsx
##########
@@ -29,14 +30,59 @@ import {
Table,
} from 'react-virtualized';
import { getTextDimension } from '@superset-ui/dimension';
+import { t } from '@superset-ui/translation';
+
+import Button from '../Button';
+import CopyToClipboard from '../CopyToClipboard';
+import ModalTrigger from '../ModalTrigger';
import TooltipWrapper from '../TooltipWrapper';
function getTextWidth(text, font = '12px Roboto') {
return getTextDimension({ text, style: { font } }).width;
}
+function getJsonStringifiedObject(data) {
Review comment:
NIT (optional): naming `safeJsonParse`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
