eschutho opened a new pull request, #35721:
URL: https://github.com/apache/superset/pull/35721

   ### SUMMARY
   This PR adds test coverage for the `log_task_failure` signal handler that 
was introduced in #35595.
   
   The original PR added the signal handler to log Celery task failures, but 
did not include tests. This follow-up PR adds comprehensive test coverage for 
the handler.
   
   Related to #35595
   
   ### TESTING INSTRUCTIONS
   Run the new tests:
   ```bash
   pytest 
tests/integration_tests/reports/scheduler_tests.py::test_log_task_failure_with_sender
 
tests/integration_tests/reports/scheduler_tests.py::test_log_task_failure_without_sender
 -v
   ```
   
   Both tests should pass, verifying:
   - The handler logs correctly when a task sender is provided
   - The handler gracefully handles None sender and logs "Unknown"
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue: Related to #35595
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to