bito-code-review[bot] commented on code in PR #35378:
URL: https://github.com/apache/superset/pull/35378#discussion_r2393655646
##########
docs/yarn.lock:
##########
@@ -1583,6 +1583,27 @@
fs-extra "^11.1.1"
tslib "^2.6.0"
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Version mismatch in dependencies</b></div>
<div id="fix">
The yarn.lock file is adding Docusaurus 3.9.1 packages
(@docusaurus/[email protected], @docusaurus/[email protected], @docusaurus/[email protected])
while package.json still specifies version 3.8.1 for @docusaurus/core,
@docusaurus/plugin-client-redirects, and @docusaurus/preset-classic. This
version mismatch between the lockfile and package.json will cause dependency
resolution conflicts and potential build failures. Update package.json to use
consistent 3.9.1 versions across all Docusaurus packages.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/package.json
+++ b/docs/package.json
@@ -31,8 +31,8 @@
"@ant-design/icons": "^6.0.0",
- "@docusaurus/core": "3.8.1",
- "@docusaurus/plugin-client-redirects": "3.8.1",
- "@docusaurus/preset-classic": "3.8.1",
+ "@docusaurus/core": "3.9.1",
+ "@docusaurus/plugin-client-redirects": "3.9.1",
+ "@docusaurus/preset-classic": "3.9.1",
"@docusaurus/theme-mermaid": "^3.9.1",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35378#issuecomment-3355015413>#4b7577</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -2065,6 +2281,33 @@
utility-types "^3.10.0"
webpack "^5.88.1"
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Docusaurus version mismatch</b></div>
<div id="fix">
Critical version mismatch detected: `@docusaurus/[email protected]` is being added
while core packages (`@docusaurus/core`, `@docusaurus/plugin-client-redirects`,
`@docusaurus/preset-classic`) remain locked to `3.8.1`. This creates a
high-risk compatibility issue that could break the documentation build process.
The system is running Node.js v20.12.1 which meets Docusaurus 3.9 requirements,
but all Docusaurus packages must be aligned to the same major/minor version.
Update package.json to use `^3.9.1` for all @docusaurus dependencies to ensure
consistency.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- "@docusaurus/core": "3.8.1",
- "@docusaurus/plugin-client-redirects": "3.8.1",
- "@docusaurus/preset-classic": "3.8.1",
+ "@docusaurus/core": "^3.9.1",
+ "@docusaurus/plugin-client-redirects": "^3.9.1",
+ "@docusaurus/preset-classic": "^3.9.1",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35378#issuecomment-3355015413>#4b7577</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -13840,6 +14256,40 @@ webpack-dev-server@^4.15.2:
webpack-dev-middleware "^5.3.4"
ws "^8.13.0"
+webpack-dev-server@^5.2.2:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>webpack-dev-server breaking change</b></div>
<div id="fix">
The webpack-dev-server upgrade from 4.15.2 to 5.2.2 introduces breaking
changes that will prevent the Docusaurus development server from starting.
Version 5.x has stricter security policies, deprecated configuration options,
and requires explicit `allowedHosts` configuration. This will break the `yarn
start` command and local documentation development workflow. Pin
webpack-dev-server to 4.15.2 using Yarn resolutions to maintain compatibility
with Docusaurus 3.8.1.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- "version:remove:components": "node scripts/manage-versions.mjs remove
components",
- },
- "dependencies": {
+ "version:remove:components": "node scripts/manage-versions.mjs remove
components",
+ },
+ "resolutions": {
+ "webpack-dev-server": "4.15.2"
+ },
+ "dependencies": {
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35378#issuecomment-3355015413>#4b7577</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
