rusackas commented on issue #13345:
URL: https://github.com/apache/superset/issues/13345#issuecomment-3388298283
@gelila-s that'd be great! I'll just ping @dpgaspar @michael-s-molina
@villebro @mistercrunch here in case they have feelings about the correct
approach here.
I'm not personally close to the issue at hand (rarely do I delete a user, if
ever) but I think some general things to keep in mind would be about being
extra cautious/safe here.
* Might it warrant an extra confirmation (i.e. "You'll be removing {stuff
here}. Type DELETE to continue") since this may be unsafe
* If any of the records to be deleted have value to other users (which
doesn't seem to be the case) it would be good to reassign them to another user.
Sounds like this isn't a concern here though.
* I'm _not_ sure if some things like `logs` have use for certain orgs, like
a permanent audit trail for legal/governance purposes. Maybe they're safe to
delete, but if not, it _seems_ possible to update the log's `user_id` from `X`
to `DELETED_X`?
It's a whole other can of worms (and a much larger project) but eventually I
would love to see more (or all!) tables in Superset support a "soft delete"
where a new column in the table (i.e. a boolean "deleted" column) gets set, and
those deleted records are effectively filtered out and ignored throughout
Superset. Then they'd be recoverable in an emergency... like if you bring that
user back later, or someone accidentally deletes a dashboard, your DBA could go
in and hand-tweak the record(s) to restore things.
Anyway, that's a long-winded way of saying "heck yeah, go for it!" but just
erring on the side of caution when/where it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
