jakubhruby opened a new pull request, #35640:
URL: https://github.com/apache/superset/pull/35640

   ### SUMMARY
   Translations need to be fully loaded before app is started - it's in 
`superset-frontend/src/preamble.ts` where there even is a comment saying `Load 
language pack before anything else`, but in fact there is no wait for async 
translation load. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before - translated and non-translated mixed up 
   <img width="473" height="385" alt="Snímek obrazovky z 2025-10-14 14-17-26" 
src="https://github.com/user-attachments/assets/dfd1ccfe-25f0-4f7e-8246-2de805b07063";
 />
   
   After - all strings are loaded 
   <img width="473" height="385" alt="Snímek obrazovky z 2025-10-14 14-35-52" 
src="https://github.com/user-attachments/assets/4bc0bbd3-1948-49b9-808f-9351b04570ef";
 />
   
   
   ### TESTING INSTRUCTIONS
   Reoad page and watch all strings are translated (requires fully translated 
localization, e.g. CS added in https://github.com/apache/superset/pull/35639)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to