bito-code-review[bot] commented on code in PR #35441:
URL: https://github.com/apache/superset/pull/35441#discussion_r2396020738
##########
docs/yarn.lock:
##########
@@ -1583,6 +1583,27 @@
fs-extra "^11.1.1"
tslib "^2.6.0"
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Version mismatch in dependencies</b></div>
<div id="fix">
The yarn.lock file is being updated to include @docusaurus/[email protected], but
this creates a version mismatch with the existing
@docusaurus/[email protected] and @docusaurus/[email protected]
specified in package.json. This version inconsistency between core (3.9.1) and
plugins (3.8.1) can cause runtime errors during build/serve operations due to
incompatible internal APIs and dependency resolution conflicts.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- docs/package.json
+++ docs/package.json
@@ -31,4 +31,4 @@
"@docusaurus/core": "3.9.1",
- "@docusaurus/plugin-client-redirects": "3.8.1",
- "@docusaurus/preset-classic": "3.8.1",
- "@docusaurus/theme-mermaid": "^3.8.1",
+ "@docusaurus/plugin-client-redirects": "3.9.1",
+ "@docusaurus/preset-classic": "3.9.1",
+ "@docusaurus/theme-mermaid": "3.9.1",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35441#issuecomment-3358303375>#5003d4</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -2038,6 +2209,20 @@
lodash "^4.17.21"
tslib "^2.6.0"
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Docusaurus version mismatch</b></div>
<div id="fix">
Critical version mismatch detected: `@docusaurus/core` is specified as 3.9.1
in package.json but several official Docusaurus plugins remain at 3.8.1. This
creates incompatible dependency versions that will break the build.
Specifically, `@docusaurus/[email protected]`,
`@docusaurus/[email protected]`, and `@docusaurus/[email protected]` must
be upgraded to 3.9.1 to match the core version. The yarn.lock shows both 3.8.1
and 3.9.1 versions of `@docusaurus/utils` and `@docusaurus/utils-validation`
being installed simultaneously, which will cause runtime conflicts.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/package.json
+++ b/docs/package.json
@@ -32,10 +32,10 @@
"dependencies": {
"@ant-design/icons": "^6.0.0",
"@docusaurus/core": "3.9.1",
- "@docusaurus/plugin-client-redirects": "3.8.1",
- "@docusaurus/preset-classic": "3.8.1",
- "@docusaurus/theme-mermaid": "^3.8.1",
+ "@docusaurus/plugin-client-redirects": "3.9.1",
+ "@docusaurus/preset-classic": "3.9.1",
+ "@docusaurus/theme-mermaid": "^3.9.1",
"@emotion/core": "^10.0.27",
"@emotion/react": "^11.13.3",
"@emotion/styled": "^10.0.27",
@@ -71,8 +71,8 @@
},
"devDependencies": {
- "@docusaurus/module-type-aliases": "^3.8.1",
- "@docusaurus/tsconfig": "^3.8.1",
+ "@docusaurus/module-type-aliases": "^3.9.1",
+ "@docusaurus/tsconfig": "^3.9.1",
"@eslint/js": "^9.32.0",
"@types/react": "^19.1.8",
"@typescript-eslint/eslint-plugin": "^8.37.0",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35441#issuecomment-3358303375>#5003d4</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -1709,6 +1826,36 @@
vfile "^6.0.1"
webpack "^5.88.1"
+"@docusaurus/[email protected]":
+ version "3.9.1"
+ resolved
"https://registry.yarnpkg.com/@docusaurus/mdx-loader/-/mdx-loader-3.9.1.tgz#0ef77bee13450c83c18338f8e5f1753ed2e9ee3f";
+ integrity
sha512-/1PY8lqry8jCt0qZddJSpc0U2sH6XC27kVJZfpA7o2TiQ3mdBQyH5AVbj/B2m682B1ounE+XjI0LdpOkAQLPoA==
+ dependencies:
+ "@docusaurus/logger" "3.9.1"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Version mismatch conflict</b></div>
<div id="fix">
Critical version mismatch detected: `@docusaurus/core` is specified as 3.9.1
in package.json but `@docusaurus/[email protected]` depends on
`@docusaurus/[email protected]` and `@docusaurus/[email protected]`, while other packages
like `@docusaurus/[email protected]` and
`@docusaurus/[email protected]` are still locked to 3.8.1. This mixed
version state will cause runtime errors and build failures due to incompatible
internal APIs between 3.8.x and 3.9.x components.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/package.json
+++ b/docs/package.json
@@ -32,8 +32,8 @@
"@ant-design/icons": "^6.0.0",
"@docusaurus/core": "3.9.1",
- "@docusaurus/plugin-client-redirects": "3.8.1",
- "@docusaurus/preset-classic": "3.8.1",
- "@docusaurus/theme-mermaid": "^3.8.1",
+ "@docusaurus/plugin-client-redirects": "3.9.1",
+ "@docusaurus/preset-classic": "3.9.1",
+ "@docusaurus/theme-mermaid": "^3.9.1",
"@emotion/core": "^10.0.27",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35441#issuecomment-3358303375>#5003d4</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
