eschutho commented on code in PR #35591:
URL: https://github.com/apache/superset/pull/35591#discussion_r2427096322
##########
superset/commands/report/execute.py:
##########
@@ -419,7 +419,18 @@ def _get_csv_data(self) -> bytes:
logger.info("Getting chart from %s as user %s", url, user.username)
csv_data = get_chart_csv_data(chart_url=url,
auth_cookies=auth_cookies)
except SoftTimeLimitExceeded as ex:
- raise ReportScheduleCsvTimeout() from ex
+ chart_id = self._report_schedule.chart_id
+ chart_name = self._report_schedule.chart.slice_name
+ timeout = self._report_schedule.working_timeout or app.config.get(
+ "ALERT_REPORTS_DEFAULT_WORKING_TIMEOUT", 3600
+ )
+ error_msg = (
+ f"Timeout fetching CSV data for chart '{chart_name}' "
Review Comment:
Can we log the execution if instead of chart name? It will make lookup
easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]