giacomochiarella commented on code in PR #34111:
URL: https://github.com/apache/superset/pull/34111#discussion_r2442418414
##########
superset/sql_lab.py:
##########
@@ -475,7 +475,9 @@ def execute_sql_statements( # noqa: C901
db.session.commit()
# Hook to allow environment-specific mutation (usually comments)
to the SQL
- query.executed_sql = database.mutate_sql_based_on_config(block)
+ query.executed_sql = database.mutate_sql_based_on_config(
+ block, is_split=config["MUTATE_AFTER_SPLIT"]
Review Comment:
Actually, reading the comment
[here](https://github.com/apache/superset/blob/0b3fe3d60ccbb5d80370af3baafcd74879d34de6/superset/config.py#L1635),
I understand what we want to do can be already achieved but it is misleading
given this PR because it looks to me it is not true the statement "...a SET
ROLE statement alongside every user query..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
