kgabryje commented on code in PR #33831:
URL: https://github.com/apache/superset/pull/33831#discussion_r2426501380
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -50,31 +52,82 @@ import { FilterBarOrientation, RootState } from
'src/dashboard/types';
import {
DropdownContainer,
type DropdownRef as DropdownContainerRef,
+ Typography,
} from '@superset-ui/core/components';
import { Icons } from '@superset-ui/core/components/Icons';
import { useChartIds } from 'src/dashboard/util/charts/useChartIds';
import { useChartLayoutItems } from 'src/dashboard/util/useChartLayoutItems';
+import { ChartCustomizationItem } from
'src/dashboard/components/nativeFilters/ChartCustomization/types';
import { FiltersOutOfScopeCollapsible } from '../FiltersOutOfScopeCollapsible';
import { useFilterControlFactory } from '../useFilterControlFactory';
import { FiltersDropdownContent } from '../FiltersDropdownContent';
import crossFiltersSelector from '../CrossFilters/selectors';
import CrossFilter from '../CrossFilters/CrossFilter';
import { useFilterOutlined } from '../useFilterOutlined';
import { useChartsVerboseMaps } from '../utils';
+import GroupByFilterCard from '../../ChartCustomization/GroupByFilterCard';
+import { selectChartCustomizationItems } from
'../../ChartCustomization/selectors';
type FilterControlsProps = {
dataMaskSelected: DataMaskStateWithId;
onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void;
clearAllTriggers?: Record<string, boolean>;
onClearAllComplete?: (filterId: string) => void;
+ hideHeader?: boolean;
};
+const SectionContainer = styled.div`
+ margin-bottom: ${({ theme }) => theme.sizeUnit * 3}px;
+`;
+
+const SectionHeader = styled.div`
+ display: flex;
+ align-items: center;
+ justify-content: space-between;
+ padding: ${({ theme }) => theme.sizeUnit * 2}px 0;
+ cursor: pointer;
+ user-select: none;
+
+ &:hover {
+ background: ${({ theme }) => theme.colorBgTextHover};
+ margin: 0 -${({ theme }) => theme.sizeUnit * 2}px;
+ padding: ${({ theme }) => theme.sizeUnit * 2}px;
+ border-radius: ${({ theme }) => theme.sizeUnit}px;
Review Comment:
`theme.borderRadius`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
