mistercrunch commented on code in PR #31282:
URL: https://github.com/apache/superset/pull/31282#discussion_r2371379976
##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -97,6 +97,7 @@ class TextAreaControl extends Component {
return (
<TextAreaEditor
+ {...this.props}
Review Comment:
Seem to me both before/after this PR can have issue or create confusion,
seems we just use the `...rest` pattern as in
https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx#L37
##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -97,6 +97,7 @@ class TextAreaControl extends Component {
return (
<TextAreaEditor
+ {...this.props}
Review Comment:
Seem to me both before/after this PR can have issue or create confusion,
seems we should use the `...rest` pattern as in
https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx#L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
