sadpandajoe commented on code in PR #35622:
URL: https://github.com/apache/superset/pull/35622#discussion_r2433653905
##########
superset/tasks/slack.py:
##########
@@ -26,10 +26,23 @@
@celery_app.task(name="slack.cache_channels")
def cache_channels() -> None:
+ cache_timeout = current_app.config["SLACK_CACHE_TIMEOUT"]
+ retry_count = current_app.config.get("SLACK_API_RATE_LIMIT_RETRY_COUNT", 5)
Review Comment:
```suggestion
retry_count = current_app.config.get("SLACK_API_RATE_LIMIT_RETRY_COUNT",
2)
```
We should probably default this to 2 everywhere if you say your PR is
backwards compatible as the current retry count is 2. People who want more can
use the config to bump it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
