dosubot[bot] commented on issue #35674: URL: https://github.com/apache/superset/issues/35674#issuecomment-3409444227
<!-- Answer --> Based on recent changes and the current implementation, when you edit a filter and select a dataset, the frontend determines which charts the filter applies to by matching the selected dataset ID with each chart's dataset. If the dataset IDs don't match, the filter won't affect those charts, and they may be excluded from the filter's scope in the UI. This logic is handled in the filter configuration modal and form components, specifically in how `initiallyExcludedCharts` is computed and how the `DatasetSelect` component updates the filter state. Any mismatch or failure to propagate the new dataset ID can cause the filter not to take effect visually, even if the backend responds correctly. Recent PRs have touched related logic, such as dependency arrays and sorting, but no direct fix for this specific issue has been merged yet ([example](https://github.com/apache/superset/pull/34539)). If you haven't already, check for any errors in the browser console when this happens, as a JavaScript error or state update issue could prevent the UI from rendering the filter effect. Also, ensure that the dataset selection is correctly updating the filter's dataset ID and that the charts you expect to be filtered are using the same dataset. If the issue persists, it may be worth reviewing the logic in `FiltersConfigForm.tsx` and related components to ensure state updates and dataset ID propagation are working as intended. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/c6e3a7f6-2a78-46a7-afda-25fd91366525?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/35674) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
