villebro commented on PR #35621: URL: https://github.com/apache/superset/pull/35621#issuecomment-3407805521
> @dpgaspar How do we handle existing data? Hash values are used for content that can be regenerated such as cache, thumbnails, etc but also for content that can't be regenerated like meta store entries that use the `key_value` function such as permalinks, app configs, etc. > > I think the correct way of solving this is to add the algorithm that was used to hash the value in the database. We could create a migration that adds the algorithm column set to MD5 for all existing values. Then, we create a function that parses the hashes based on the saved algorithm. This way, admins can change `HASH_ALGORITHM` multiple times without breaking anything. I agree on @michael-s-molina 's proposal. For fresh installs this is ofc not a problem, but without a simple migration tool it will be difficult to benefit from these improvements on existing deployments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
