msyavuz commented on code in PR #35336:
URL: https://github.com/apache/superset/pull/35336#discussion_r2392525872
##########
superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.test.jsx:
##########
@@ -335,4 +341,89 @@ describe('Markdown', () => {
// Check that width is no longer 248px
expect(updatedParent).not.toHaveStyle('width: 248px');
});
+
+ test('shouldFocusMarkdown returns true when clicking inside markdown
container', async () => {
+ await setup({ editMode: true });
+
+ const markdownContainer = screen.getByTestId(
+ 'dashboard-component-chart-holder',
+ );
+
+ await act(async () => {
+ await userEvent.click(markdownContainer);
+ });
Review Comment:
Now do we need act? awaiting userEvent should be enough, i was trying to get
rid of `act` with the previous review 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
