LevisNgigi opened a new pull request, #35289: URL: https://github.com/apache/superset/pull/35289
fix(database-modal): fix issue where commas could not be typed into DB configuration. ### SUMMARY The reducer always stripped empty strings when updating schemas_allowed_for_file_upload, so a user ending the input with a comma lost the intended trailing placeholder. Now we detect a trailing comma and preserves an empty string in the array (['']) to reflect that state, allowing the UI to keep an open slot for adding another schema. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF AFTER <img width="748" height="775" alt="Screenshot from 2025-09-25 15-01-43" src="https://github.com/user-attachments/assets/c9ac59de-b5f9-4cdd-ba84-133ce37271a8"; /> ### TESTING INSTRUCTIONS Reproduction steps: -> Click into database connections -> Edit a database -> Advanced options -> Limit upload permissions to specific schemas -> Attempt to upload desired schemas as comma separated values by typing names of desired schemas with separating commas -> one should be able to now separate schemas using commas. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
