bito-code-review[bot] commented on code in PR #35369:
URL: https://github.com/apache/superset/pull/35369#discussion_r2393650381
##########
docs/yarn.lock:
##########
@@ -2433,11 +2433,16 @@
minimatch "^3.1.2"
strip-json-comments "^3.1.1"
-"@eslint/[email protected]", "@eslint/js@^9.32.0":
+"@eslint/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken dependency resolution</b></div>
<div id="fix">
The yarn.lock change removes the shared resolution for `@eslint/js@^9.32.0`
which breaks dependency resolution for any packages that depend on the
`^9.32.0` range. This will cause yarn to potentially install multiple versions
of `@eslint/js` or fail to resolve dependencies. Restore the shared resolution
entry to maintain compatibility with existing dependencies while still allowing
the new 9.36.0 version.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
"@eslint/[email protected]", "@eslint/js@^9.32.0":
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35369#issuecomment-3355012142>#fc1dda</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
