gabotorresruiz commented on PR #35663: URL: https://github.com/apache/superset/pull/35663#issuecomment-3411700286
Hey @geido I only have one concern related to how we should handle local storage. Your changes introduces direct `localStorage` access in `ThemeList/index.tsx` with a new storage key `(superset-applied-theme-id)` that bypasses the existing `ThemeController` storage abstraction (take a look into the `setTemporaryTheme` or `clearLocalOverrides` functions in `ThemeController`). I'm wondering if we should create a solution that involves maybe we can create or modifying something in `ThemeController` that handles this `localStorage` issue instead of creating a new `localStorage` system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
