rusackas commented on issue #35655: URL: https://github.com/apache/superset/issues/35655#issuecomment-3423016232
I think the proposal is great (not that I'm biased or anything hehehe) but it probably doesn't need a SIP. We'll number it and follow the process, but there's nothing stopping you from opening a POC pull request (which we might merge). Writing any level of tests to make sure the control panel works as intended before and after the migration would be _wonderful_. I would advise starting quite small... just pick ONE control as a react compnet that could be implemented and tested, then we can look at the pattern and start implementing across additional control panels and controls. I'd rather review a thousand small PRs than have one gigantic PR that we'll never feel safe merging, so let's just take a whole lot of cuts at it and call it a roadmap :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
